Incorrect path resolution for nbb.edn local deps

[logseq-cldwalker]

Hi @borkdude

version

1.2.172

platform

osx 12.0.1 and node 18.14.1

problem

When using a local dep e.g. {:local/root "deps/bar"} in nbb.edn, nbb resolves local paths to be three directories deep in .nbb/ instead of the current directory. I think I started seeing this when upgrading nbb-logseq to 1.1.X.

repro

Basic repro at https://github.com/logseq-cldwalker/nbb-local-deps-repro. A more involved, nbb-logseq version of this issue exists at https://github.com/logseq/logseq/pull/9033/files#diff-fc5061296a8adfb6800fdedc2f3d0ab5b6ce8f8b7c55f4f9d737c1f4a73e768c

expected behavior

I expected to use a local dep the same way we use one in deps.edn. A temporary workaround is to change {:local/root "../../../deps/bar"}. However this workaround doesn't consistently work on CI and locally

[borkdude]

I noticed this too. The fix should be made here:

nbb/src/nbb/impl/deps.cljs

Line 35 in 2c19bc8

(cproc/execSync (str bb " --config " deps-edn-path " uberjar " jar-path))

by adding a --deps-root argument, setting that to the parent dir of the invoked script.

[borkdude]

Fixed in 1.2.173

[logseq-cldwalker]

Thanks! That was quick. 😍 Confirmed it works great for the repro. Cutting a nbb-logseq release shortly