Skip to content

Commit

Permalink
Update dependencies and run all tests (#745)
Browse files Browse the repository at this point in the history
  • Loading branch information
@danez
danez authored Dec 6, 2018
1 parent 2c61de5 commit 6df8af1
Show file tree
Hide file tree
Showing 4 changed files with 2,456 additions and 2,306 deletions.
4 changes: 1 addition & 3 deletions .eslintrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
"es6": true,
"node": true
},
"extends": ["eslint-config-babel"],
"extends": ["eslint-config-babel", "eslint-config-prettier"],
"plugins": ["prettier"],
"rules": {
"arrow-parens": "off",
"quotes": "off",
"prettier/prettier": ["error", { "trailingComma": "all" }]
}
}
35 changes: 18 additions & 17 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"node": ">= 6.9"
},
"dependencies": {
"find-cache-dir": "^1.0.0",
"find-cache-dir": "^2.0.0",
"loader-utils": "^1.0.2",
"mkdirp": "^0.5.1",
"util.promisify": "^1.0.0"
Expand All @@ -20,25 +20,26 @@
"webpack": ">=2"
},
"devDependencies": {
"@babel/cli": "^7.0.0",
"@babel/core": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/cli": "^7.2.0",
"@babel/core": "^7.2.0",
"@babel/preset-env": "^7.2.0",
"ava": "0.25.0",
"babel-eslint": "^8.0.0",
"babel-plugin-istanbul": "^4.0.0",
"babel-plugin-react-intl": "^2.1.3",
"cross-env": "^5.0.0",
"eslint": "^4.1.0",
"eslint-config-babel": "^8.0.0",
"eslint-plugin-flowtype": "^2.25.0",
"eslint-plugin-prettier": "^2.1.2",
"husky": "^0.14.0",
"lint-staged": "^7.1.0",
"nyc": "^11.0.1",
"prettier": "^1.2.2",
"babel-eslint": "^10.0.1",
"babel-plugin-istanbul": "^5.1.0",
"babel-plugin-react-intl": "^3.0.1",
"cross-env": "^5.2.0",
"eslint": "^5.9.0",
"eslint-config-babel": "^8.0.2",
"eslint-config-prettier": "^3.3.0",
"eslint-plugin-flowtype": "^3.2.0",
"eslint-plugin-prettier": "^3.0.0",
"husky": "^1.2.0",
"lint-staged": "^8.1.0",
"nyc": "^13.1.0",
"prettier": "^1.15.3",
"react": "^16.0.0",
"react-intl": "^2.1.2",
"react-intl-webpack-plugin": "^0.0.3",
"react-intl-webpack-plugin": "^0.3.0",
"rimraf": "^2.4.3",
"webpack": "^4.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions test/sourcemaps.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ test.cb("should output webpack's devtoolModuleFilename option", t => {
});
});

test.only.cb("should disable sourcemap output with 'sourceMaps:false'", t => {
test.cb("should disable sourcemap output with 'sourceMaps:false'", t => {
const config = Object.assign({}, globalConfig, {
devtool: "source-map",
output: {
Expand Down Expand Up @@ -224,7 +224,7 @@ test.only.cb("should disable sourcemap output with 'sourceMaps:false'", t => {
});
});

test.only.cb("should disable sourcemap output with 'sourceMap:false'", t => {
test.cb("should disable sourcemap output with 'sourceMap:false'", t => {
const config = Object.assign({}, globalConfig, {
devtool: "source-map",
output: {
Expand Down
Loading

3 comments on commit 6df8af1

@realityking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danez Any chance you could cut a release that includes this commit? 🙏

@loganfsmyth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@realityking Howcome exactly? It seems like mostly internal implementation details.

@realityking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganfsmyth Deduplication of find-cache-dir. babel-loader is (alphabetically) the first version to depend on it so it (and it dependencies) "win" that it's being pulled up by npm. All other dependencies using find-cache-dir v2 get their own copies.

Please sign in to comment.