Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'sourceMaps' since that is what we suggest to use in our docs. #670

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

loganfsmyth
Copy link
Member

Fixes #658

Babel allows both 'sourceMap' and 'sourceMaps'. Not only were we using the wrong one (because our docs recommend 'sourceMaps', but we were also causing Babel to always throw an unhelpful error when the user used the wrong one.

@loganfsmyth loganfsmyth merged commit ea52d05 into babel:master Sep 2, 2018
@loganfsmyth loganfsmyth deleted the default-sourceMaps branch September 2, 2018 23:25
@jdalton
Copy link
Member

jdalton commented Sep 2, 2018

Thank you @loganfsmyth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants