Throw upgrade error when babel version is less than 6.14.0 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
boopathi
commented
Aug 27, 2016
•
boopathi
commented
- (Close Set hard dependency on babel.version #70)
- related Minimum browser support is unclear #114
- (Close Webpack Issues #106)
| @@ -1,20 +1,53 @@ | |||
| const err = new Error("Babili is supported only for babel version >=6.14.0"); | |||
There was a problem hiding this comment.
We can be more specific here - babel is babel-core. Can explain you need to update babel-core, or cli, etc
|
|
||
| function isVersion(versionStr) { | ||
| const version = versionStr.split(".").map((p) => parseInt(p)); | ||
| if (version[0] >= 6 && version[1] >= 14) { |
There was a problem hiding this comment.
return version[0] >= 6 && version[1] >= 14 ? :)
|
thanks! |
|
|
||
| function isVersion(versionStr) { | ||
| const version = versionStr.split(".").map((p) => parseInt(p)); | ||
| return version[0] >= 6 && version[1] >= 14; |
There was a problem hiding this comment.
Should we do === 6 instead of >= 6?
There was a problem hiding this comment.
this is reverted. because it seems not possible to check version in preset.
But yeah, cool.. it should be ===6
There was a problem hiding this comment.
Oh weird. I'd have expected the version to show up properly.
There was a problem hiding this comment.
It does show up properly. But problems in supporting older versions.
- Older versions of babel only accept an object
- Newer versions when they accept an object with
key = pluginsdon't executebuildPreset- so no plugin is applied in preset. - We use
nameproperty to measure performance of each plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.