Add more tests for DCE'ing conditional expressions #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdesjardins
commented
Oct 23, 2016
| }); | ||
|
|
||
| it("should evaluate conditional expressions 5", () => { | ||
| const source = "'foo' === 'foo' ? a() : b();"; |
There was a problem hiding this comment.
I wasn't sure if the assumption was that 'foo' === 'foo' would be reduced to true by constant folding, but I didn't see any tests for that in the constant folding plugin.
So if you prefer I can move these two to constant-folding-test.js
|
Thanks! |
hzoo
added
the
Tag: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which involve a couple more complex conditions than
trueorfalse