Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if_return & dce ifelse..return within loops #266

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Fix if_return & dce ifelse..return within loops #266

merged 1 commit into from
Nov 15, 2016

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Nov 13, 2016 •
edited
Loading

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Nov 13, 2016
boopathi
boopathi commented Nov 13, 2016
View reviewed changes
packages/babel-plugin-minify-dead-code-elimination/__tests__/dead-code-elimination-test.js
}, babelOpts)).code.trim();
}

function transformWithSimplify(code) {
Copy link
Member Author

@boopathi boopathi Nov 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not necessary. Will remove it.

Will keep it and add more tests. since this covers one more optimization from simplify.

Edit: ^ DONE

boopathi
boopathi commented Nov 13, 2016
View reviewed changes
packages/babel-plugin-minify-simplify/__tests__/simplify-test.js
} catch (e) {
doOtherThings();
}
doThings();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this happened.

@boopathi
Copy link
Member Author

Failing test: regexp-constructors.

@boopathi boopathi force-pushed the if-return-0 branch 2 times, most recently from 52ac43c to 06495b8 Compare November 14, 2016 21:58
@boopathi
Fix if_return & dce ifelse..return within loops
c949663 
+ (Close #265)
+ (Close #257)

Fix lint

Add more tests specific to bug fix

Fix dce - test case
@boopathi boopathi mentioned this pull request Nov 15, 2016
Closed
@kangax kangax merged commit 6bdb439 into master Nov 15, 2016
@kangax kangax deleted the if-return-0 branch November 15, 2016 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boopathi @kangax