Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove comments by default in babel-preset-babili #325

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Dec 5, 2016

Then we don't have to modify the readme unless we want to say somewhere it also removes comments.

This can be a bug fix (it was supposed to remove comments) or breaking change (it wasn't removing it before)

  • test

@boopathi
Copy link
Member

boopathi commented Dec 5, 2016

I think the default should be to preserve @preserve and @license comments

@hzoo
Copy link
Member Author

hzoo commented Dec 5, 2016

Oh is that not the default?

@boopathi
Copy link
Member

boopathi commented Dec 5, 2016

Ah. Cool. I was thinking comments: false will remove all comments.

Copy link
Member

@boopathi boopathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Dec 5, 2016
@kangax kangax merged commit ab98c72 into master Dec 6, 2016
@kangax kangax deleted the rm-comments branch December 6, 2016 23:38
@activedecay
Copy link

Then we don't have to modify the readme unless we want to say somewhere it also removes comments.

well, i'm using your package, but i don't know how to remove comments, any help would be appreciated.

var gulp = require('gulp')
var babel = require('gulp-babel')
var fs = require('fs');

exports.task = function () {
    return gulp.src('e2e/test/pages/**.js')
        .pipe(babel({presets: ['babili']}))
        // i want to remove comments here
        .pipe(gulp.dest('e2e/lib'))
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants