fix builtins plugins from leaking vars #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
reviewed
Mar 9, 2017
| const { start: nodeStart } = firstPath.parent; | ||
| const { end: nodeEnd } = lastPath.parent; | ||
|
|
||
| program.traverse({ |
There was a problem hiding this comment.
the same can be achieved by getFunctionParent recursively till program. program.traverse inside a loop will be costly.
|
[Update] Running mangler on exit fixes #425. |
|
Still leaks when there is no top level IIFE and functions are at same level. Trying out some stuffs. |
vigneshshanmugam
force-pushed
the
builtins
branch
from
b7a3ddf to
0eae9a9
Compare
vigneshshanmugam
force-pushed
the
builtins
branch
from
0eae9a9 to
68ece87
Compare
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 82.38% 82.49% +0.11%
==========================================
Files 35 35
Lines 2611 2634 +23
Branches 923 930 +7
==========================================
+ Hits 2151 2173 +22
- Misses 280 281 +1
Partials 180 180
Continue to review full report at Codecov.
|
|
Works now for functions at same level. |
boopathi
approved these changes
Mar 22, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #461
Even after fixing this, the mangler doesn't rename the identifier properly. Related - #425