Remove redundant use strict (Fix #542) #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 82.89% 82.93% +0.04%
==========================================
Files 40 41 +1
Lines 2719 2743 +24
Branches 952 958 +6
==========================================
+ Hits 2254 2275 +21
- Misses 281 282 +1
- Partials 184 186 +2
Continue to review full report at Codecov.
|
| * @param {NodePath} block BlockStatement | ||
| */ | ||
| function removeUseStrict(block) { | ||
| if (!block.isBlockStatement()) { |
There was a problem hiding this comment.
why is this check even needed if its already checked before.
There was a problem hiding this comment.
since it is a separate file. to not shoot ourselves in foot by calling removeUseStrict(SomeOtherPath)
There was a problem hiding this comment.
Cool! didn't realise it was a separate module.
vigneshshanmugam
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.