Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up before every run to avoid working on already minified file #557

Merged
merged 1 commit into from
May 25, 2017

Conversation

buunguyen
Copy link
Member

Fixes #538.

Approach taken: perform a cleanup before a every run. Alternative: cleanup at failure.

I chose the former because:

  • It's more robust. There could be interruption other than failure.
  • Upon failure, (I guess) the minified file might be useful for troubleshooting.

@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #557 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   82.89%   82.93%   +0.03%     
==========================================
  Files          40       40              
  Lines        2719     2719              
  Branches      952      952              
==========================================
+ Hits         2254     2255       +1     
+ Misses        281      280       -1     
  Partials      184      184
Impacted Files Coverage Δ
packages/babel-plugin-minify-simplify/src/index.js 80.74% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca00355...b60bee2. Read the comment docs.

@boopathi
Copy link
Member

Thanks.

@boopathi boopathi merged commit 867d8fb into babel:master May 25, 2017
@boopathi boopathi added the Tag: Internal Pull Request changing project internals - code that is NOT published label May 25, 2017
@buunguyen buunguyen deleted the cleanup-smoke-test branch October 5, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Internal Pull Request changing project internals - code that is NOT published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants