Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

(Discussion): Split Class/Property decorators plugin (Stage 2) from Stage 0 proposal #237

Closed
DrewML opened this issue Nov 25, 2016 · 8 comments

Comments

@DrewML
Copy link
Member

DrewML commented Nov 25, 2016

The decorators plugin currently enables support for the following proposals:

Is anyone opposed to breaking these out to separate plugins?

@loganfsmyth
Copy link
Member

I didn't realize we supported function expression decorators, are you sure?

@DrewML
Copy link
Member Author

DrewML commented Nov 25, 2016

I didn't realize we supported function expression decorators, are you sure?

Updated the OP - I got that backwards. We currently support method param decorators, but not function expression decorators.

@danez
Copy link
Member

danez commented Nov 25, 2016

If the proposals are splitted, we should also have seperate plugins I think. But we should be carefully and not break users currently using decorators already. So maybe 3 new plugins and leave the current decorator plugin as is?

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Dec 8, 2016

Please don't forget that spec still can have breaking changes so we probably need to think about naming before publish. This is unlikely will affect parser but anyway..

babel-plugin-transform-decorators-legacy2? 😄

@hzoo
Copy link
Member

hzoo commented Dec 8, 2016

Ref babel/babel#4955

  • remove stage presets
  • independently versioned transforms in a separate monorepo, move to main repo after es20xx
  • expose parser plugins externally with a whitelist, make syntax plugins independent from babylon core.

@hzoo
Copy link
Member

hzoo commented Jun 22, 2017

#587 with the decorators2 plugin handles Class/Property decorators: Stage 2

@hzoo
Copy link
Member

hzoo commented Sep 12, 2017

I think decorators2 already disallows the other two so we can close this?

@babel-bot
Copy link

This issue has been moved to babel/babel#6711.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants