Remove workaround for @babel/helper-compilation-functions bug that was fixed upstream
#450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
changed the title
bertdeblock
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
I guess we can remove the corresponding test as well?
https://github.com/babel/ember-cli-babel/blob/master/node-tests/addon-test.js#L1936-L1944
EDIT: Test is now removed.
This removes a workaround that was added for a bug in `babel-helper-compilation-targets` that was fixed upstream and is included in the version that is required by this addon. The bugfix in `babel-helpers-compilation-targets` was included in [`v7.10.2`](https://github.com/babel/babel/releases/tag/v7.10.2) `ember-cli-babel` began requiring a version of `babel-helpers-compilation-targets` that includes the bugfix since [`v7.21.0`](https://github.com/babel/ember-cli-babel/releases/tag/v7.21.0) --- - [Original bugfix workaround PR](emberjs#345) - [Dependency upgrade PR](emberjs#354) - [`ember-cli-babel@7.21.0` Release notes](https://github.com/babel/ember-cli-babel/releases/tag/v7.21.0) - [`babel-compilation-targets@7.10.2` Release notes](https://github.com/babel/babel/releases/tag/v7.10.2)
bertdeblock
force-pushed
the
remove-workaround-fixed-upstream
branch
from
134f5a0 to
f8d64cf
Compare
bertdeblock
changed the title
@babel/helper-compilation-functions bug that was fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a workaround that was added for a bug in
babel-helper-compilation-targetsthat was fixed upstream and is included in the version that is required by this addon.The bugfix in
babel-helpers-compilation-targetswas included inv7.10.2ember-cli-babelbegan requiring a version ofbabel-helpers-compilation-targetsthat includes the bugfix sincev7.21.0ember-cli-babel@7.21.0Release notesbabel-compilation-targets@7.10.2Release notes