-
Notifications
You must be signed in to change notification settings - Fork 44
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomGap doesn't affect the final size of presented view #101
Comments
Indeed the position of the drawer in the fully expanded state is fixed and it does not consider the content. I have a similar issue, where I have to use partially expanded state to accommodate the content but there is no way then to disable fully ex expanded state |
@popei69 is your issue that the drawer is not respecting the content size of the presented view or the other way around, that the content view is not respecting the size of the drawer? |
@ilyapuchka thanks for the feedback. The idea is actually to have a sticky button at all time at the bottom of the drawer regardless how far it is open, or at least when half opened and fully opened. But the rest of the page would still be scrollable. To give you an idea, I'm looking for a similar behaviour as the Instagram Share Post feature. |
yep, I think out of the box it's not supported. You could try to hack in with animation behaviour, but I doubt it will really help. |
I'm trying to place UI component depending of the size of the presented view, for instance having a button at the bottom of the drawer.
When testing it, it seems that the size of the presented view is never matching the size left from the custom gap. For instance, if I set a
.leavesCustomGap(gap: 100)
, the view presented frame won't get shorter of 100. Therefore any elements at the bottom might not be visible.I guess what I would expect is that if the drawer can have a maximum size of 500, its presented view and contained one would reflect the same size. That's not the case at the moment. Is it something available with DrawerKit?
To replicate it, inspect the view frame in a presented view controller (in
viewDidAppear
for instance), it will be the size of the screen regardless the maximum size available of the drawer.The text was updated successfully, but these errors were encountered: