Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Error on certificate validation on the last few days #34

Closed
SandroMachado opened this issue Dec 26, 2019 · 20 comments
Closed

Error on certificate validation on the last few days #34

SandroMachado opened this issue Dec 26, 2019 · 20 comments

Comments

@SandroMachado
Copy link

My certificate is about to expire and and on the last few days, some instances of my application are having problems connecting to the server. They just don't connect. Even on the same device, sometimes after installing the app it works fine, other times it just doesn't connect.

Digging in I discovered that removing this library fixes the issue. Any tip on how to fix this?

Or any ideas why this is happening?

@sheungon
Copy link

Same issue happened to me few days ago. I had to disable CT to get my app work again.

@mattmook
Copy link
Contributor

Hi @SandroMachado I don't suppose you know what value was returned by the library?

I'm thinking this may be linked to issue #28

@pavlospt
Copy link

@mattmook are there any news regarding this? We started noticing similar behaviour today in our app :)

@SandroMachado
Copy link
Author

Same here.

@jclaudino
Copy link

Same

@barnhill
Copy link

Noticing same here

@maxkohne
Copy link

We are experiencing this as well

@eramirez01
Copy link

Same Here!!!

@pavlospt
Copy link

Okay this sounds like something is certainly going on. Just to add more info here, our iOS colleagues were able to use CT fine the whole day, while we had those issues! So i guess it is not infrastructure related.

@mattmook
Copy link
Contributor

mattmook commented Feb 4, 2020

Has anyone managed to capture a log from when this happens? I suspect it could be something like the log list being out of sync with the signature, which we have seen happen once before.

@pavlospt
Copy link

pavlospt commented Feb 4, 2020

Hey @mattmook , I do not happen to have a log, but the behavior of failing to verify the signatures was like consistently inconsistent. At some it would fail to verify and then would work again. I am not sure if it has something to do with the last days of the month and an issue is going on with Date validations, but we have not seen it happen afterwards.

Just for future reference and in order to help you debug it more effectively, what would you like from us to capture? Just the raw loglist response?

@mattmook
Copy link
Contributor

mattmook commented Feb 4, 2020

When creating the certificateTransparencyInterceptor you can provide a logger, an instance of CTLogger - it might be worth recording any instances when log is called with an instance of VerificationResult.Failure.

@pavlospt
Copy link

pavlospt commented Feb 4, 2020

Yeap, we are already using that and it was outputting something along the lines of:
SSLHandshakeException: Certificate transparency failed: LogServerSignatureResult.Invalid.SignatureFailed I can get the exact log next time it happens 😄

@jclaudino
Copy link

Any updates on this issue?

Are others still experiencing this?

@pavlospt
Copy link

Haven't experienced it since the last days of January. Will wait to check it on February as well!

@pavlospt
Copy link

We had this logged in production today as well. Unfortunately we do not have any logs to share apart from:

javax.net.ssl.SSLPeerUnverifiedException: Certificate transparency failed at com.babylon.certificatetransparency.internal.verifier.CertificateTransparencyInterceptor.intercept(CertificateTransparencyInterceptor.kt:59)

@maxkohne
Copy link

Yeah, we actually disabled this library since we cannot afford to have these issues happen randomly. Our security team understands but would really like this to be solved / looked into.

I wrote about how we are remotely toggled this library in another issue: #28 (comment)

@pavlospt
Copy link

@mattmook based on this comment: #28 (comment) could we please have an update that uses the correct casing for the Signature name SHA256withRSA https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#Signature and prepare a new release?

Also since more people mentioned issues with the last days of a month, I really tend to believe something shady is going on there.

@vivascu
Copy link

vivascu commented May 8, 2020

There are some interesting findings I mentioned here: #28 (comment)

@mattmook
Copy link
Contributor

Fix released in version 0.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants