Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 366 - pspm_dcm #368

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Fix issue 366 - pspm_dcm #368

merged 4 commits into from
Apr 26, 2022

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Apr 25, 2022 •
edited
Loading

Fix pspm_dcm issue #366.

Changes proposed in this pull request:

  • Update behaviour of overwrite. The original method of overwrite is not determined by pspm_overwrite fully.
  • Fix a bug, the bug leads to incorrect downsampling of sbs_missing.

The issue proposed by our user is actually a mixture of two problems.

  1. The incorrect action of removing elements from proc_miniti
  2. The incompatibility between downsampling sbs_missing and sbs_data

@teddychao teddychao self-assigned this Apr 25, 2022
@teddychao teddychao marked this pull request as draft April 25, 2022 15:58
@teddychao teddychao added the Completed & Waiting for Review Completed and waiting for review label Apr 25, 2022
@teddychao teddychao marked this pull request as ready for review April 25, 2022 23:37
@teddychao teddychao linked an issue Apr 25, 2022 that may be closed by this pull request
DCM improvements/partial refactoring #366
Open
@teddychao teddychao added this to the v6.0.0 milestone Apr 25, 2022
@teddychao teddychao changed the title Re-fix issue 361 Fix issue 366 Apr 25, 2022
@teddychao teddychao changed the title Fix issue 366 Fix issue 366 - pspm_dcm Apr 26, 2022
@teddychao teddychao merged commit c2b0d41 into develop Apr 26, 2022
@teddychao teddychao deleted the carlos-24042022 branch April 26, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbach dominikbach dominikbach approved these changes

@jbrochar jbrochar Awaiting requested review from jbrochar

Assignees

@teddychao teddychao

Labels
Completed & Waiting for Review Completed and waiting for review
Projects
None yet
Milestone
v6.0
Development

Successfully merging this pull request may close these issues.

DCM improvements/partial refactoring
2 participants
@teddychao @dominikbach