Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager on File Browser #95

Closed
stpaultim opened this issue Jan 9, 2024 · 9 comments
Closed

Pager on File Browser #95

stpaultim opened this issue Jan 9, 2024 · 9 comments

Comments

@stpaultim
Copy link
Member

stpaultim commented Jan 9, 2024

I spun up a demo site with dev branch of Backdrop and current release of GIN. This is what the file browser looks like in Seven

image

This is what it looks like with Gin

image

I'm not sure if the page is supposed to be in the right column. But, even if it was intentional, I don't think it works very well.

I'd like to see a pager that looks more like we see with Seven.

Here is a previous issue that has been fixed related to pagers.
#72

@stpaultim
Copy link
Member Author

I think we should look at the mini-pager as well.

@laryn
Copy link
Member

laryn commented Jan 9, 2024

Thanks @stpaultim -- I don't think that is intentional. Can you do some testing on mini-pagers and report back here?

@stpaultim
Copy link
Member Author

stpaultim commented Jan 9, 2024

Here is the mini pager in Seven
image

Here it is in GIN
image

I ran across this problem, because I was unhappy with the mini-pager in GIN and thought I would try the full page, which it turned out was even worse.

@laryn

@laryn
Copy link
Member

laryn commented Jan 10, 2024

@stpaultim Turns out it was a pretty simple fix to get that reasonable. What do you think of these:

CleanShot 2024-01-10 at 17 05 31@2x

CleanShot 2024-01-10 at 17 06 28@2x

@stpaultim
Copy link
Member Author

Looks better. I'll give it a try on my site with more pages.

@laryn

@stpaultim
Copy link
Member Author

@laryn Sorry, but I'm reopening this issue as well.

The good news is that the full pager looks much better.
The bad news is that it's broken.

When I click on a page, on the pager, I go to a blank page. Link is broken somehow.

image

Is this a problem with the theme or something else?

@stpaultim stpaultim reopened this Jan 11, 2024
@laryn
Copy link
Member

laryn commented Jan 11, 2024

@stpaultim I'm not seeing an issue with the pager functionality on my local -- did you make edits in the Image Library view? Can you try reverting if so, and seeing if it makes a difference?

@stpaultim
Copy link
Member Author

@laryn - I'll do some additional experiments and see if I can figure out what is happening.

I was originally able to reproduce this problem on two sites. One development site we are working on and one fairly clean test site I set up to test CKEditor 5.

I'll do additional testing now and get back to you.

@laryn
Copy link
Member

laryn commented Feb 24, 2024

Reopen if this is still an issue.

@laryn laryn closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants