Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review: search component #994

Open
jenlampton opened this issue Jun 11, 2015 · 5 comments
Open

Design review: search component #994

jenlampton opened this issue Jun 11, 2015 · 5 comments

Comments

@jenlampton
Copy link
Member

jenlampton commented Jun 11, 2015

Is the search component design what we want it to be?

Bartik:
screen shot 2015-06-11 at 5 43 32 pm

Seven:

screen shot 2015-06-11 at 5 43 52 pm

Basis:

screen shot 2018-07-05 at 8 52 06 pm

see the d.o issue

@wesruv
Copy link
Member

wesruv commented Apr 1, 2016

Nope.

I'll take a crack at this. My ideal will probably require markup changes and have to wait until 2.x

@wesruv wesruv self-assigned this Apr 1, 2016
@klonos
Copy link
Member

klonos commented Jul 5, 2018

...I feel that the trend nowadays is to have the search button inline next to the input field. Something like this would work on Basis:

screen shot 2018-07-05 at 9 05 27 pm

@klonos
Copy link
Member

klonos commented Jul 5, 2018

@jenlampton I think that the d.org issue you link from the issue summary is about the search filter in the admin UI (as in exposed filter)

@ghost
Copy link

ghost commented Oct 12, 2020

How's this going @wesruv? Still working on this, or should we close?

@ghost ghost added the type - task label Oct 12, 2020
@wesruv wesruv removed their assignment Oct 12, 2020
@wesruv
Copy link
Member

wesruv commented Oct 12, 2020

Well, worth doing, but I dropped the ball on it. I'll unassign and let you all do what you think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants