Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support edit_uri_template by using at least mkdocs >=1.4.0 #95

Open
pjungermann opened this issue Mar 4, 2023 · 2 comments
Open

support edit_uri_template by using at least mkdocs >=1.4.0 #95

pjungermann opened this issue Mar 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pjungermann
Copy link

Release https://github.com/mkdocs/mkdocs/releases/tag/1.4.0
introduces a new feature edit_uri_template
which is a more flexible version of edit_uri.

I've prepared changes to utilize this at
https://github.com/backstage/backstage.

Note:
mkdocs v1.4.2 supports Python 3.11
https://github.com/mkdocs/mkdocs/releases/tag/1.4.2

Related: backstage/mkdocs-techdocs-core#107

@pjungermann
Copy link
Author

related to backstage/backstage#16699

@bih bih added the bug Something isn't working label Jan 4, 2024
@pjungermann
Copy link
Author

since mkdocs-techdocs-core v1.3, it requires

mkdocs>=1.5

This resolves this requirement for a more recent mkdocs version.

However, this packahe itself does not yet require mkdocs >= 1.4.0,
and it contains uses of edit_uri e.g. at mkdocs_monorepo_plugin/edit_uri.py.

In order to support edit_uri_template instead, we would require adjustments at this package still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants