Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get this to work on create-react-app #52

Closed
thtliife opened this issue Feb 12, 2017 · 5 comments
Closed

Cannot get this to work on create-react-app #52

thtliife opened this issue Feb 12, 2017 · 5 comments

Comments

@thtliife
Copy link

thtliife commented Feb 12, 2017

Has anyone successfully gotten this to work with a fork of https://github.com/facebookincubator/create-react-app ?

I cannot get it to work in either the standard or classic setup.

In standard mode, I get the following error when trying to save a link:
No permission to add a webhook to the repository facebookincubator/create-react-app. Make sure thtliife has given Backstroke permission to access this organisation or repo via OAuth.

screen shot 2017-02-13 at 9 10 31 am

In classic mode, I get the following response...

Uhh, error: {
	"message": "Validation Failed",
	"errors": [{
		"message": "The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.",
		"resource": "Search",
		"field": "q",
		"code": "invalid"
	}],
	"documentation_url": "https://developer.github.com/v3/search/"
}

Any ideas what I am doing wrong?

The create-react-app is not a private repo, as per facebook/create-react-app#1545 (comment)

@1egoman
Copy link
Collaborator

1egoman commented Feb 13, 2017

I recently discovered a bug in Backstroke, and this issue looks to be caused by it. Basically, if a source repository is not able to be written to by the user creating the Backstroke link, creating the link fails with that error that you've specified.

I've had the fix in a pull request while validating it, but I'm pretty sure it works at this point.

Here's an example link I've created:
screen shot 2017-02-12 at 6 47 18 pm

Can you confirm this fixes the issue?

I read the linked issue on create-react-app, and posted a comment on there as well. I'm going to try and clean up the documentation tonight and make it more clear how to set up and use Backstroke on a repository.

@thtliife
Copy link
Author

Hi @1egoman it looks to be ok now :)
I can successfully create a link on https://backstroke.us
and testing with curl returns

{
	"status": "ok",
	"output": {
		"status": "ok",
		"pullRequest": {
			"msg": "There's already a pull request for this repo, no need to create another."
		},
		"isEnabled": true,
		"many": false,
		"forkCount": 1
	}
}

Thanks for the fast bug fix :)

@1egoman
Copy link
Collaborator

1egoman commented Feb 13, 2017

I think this has been fixed, so I'm going to close this issue. If I missed something, let me know and I'll reopen.

@1egoman 1egoman closed this as completed Feb 13, 2017
@thtliife
Copy link
Author

seems fixed to me :)
Ill come back and let you know if something doesn't work on their next push, but quietly confident that won't be necessary :)

@gaearon
Copy link

gaearon commented Feb 13, 2017

Thank you so much for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants