Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapserver crash with meta stream #966

Closed
fuchsmich opened this issue Jan 3, 2022 · 3 comments
Closed

snapserver crash with meta stream #966

fuchsmich opened this issue Jan 3, 2022 · 3 comments
Labels
next release fixed in develop branch and will be part of the next release

Comments

@fuchsmich
Copy link
Contributor

fuchsmich commented Jan 3, 2022

Describe the bug
If there are two sources with pipes (mp3 and plattenspieler) and a meta source for both (alles), snapserver crashes, when receiving data on second pipe.

Steps to Reproduce

  1. play audio on second stream

Environment details

  • OS: Archlinux on ARM
  • Snapcast version 0.26.0
  • Installed from a AUR
$ grep -v "^#" /etc/snapserver.conf
[server]
[http]
enabled = true
bind_to_address = 0.0.0.0
doc_root = /usr/share/snapserver/snapweb
[tcp]
[stream]
bind_to_address = 0.0.0.0
source = pipe:///tmp/mpdfifo?name=mp3&mode=create
source = pipe:///tmp/vinylfifo?name=plattenspieler&mode=create
source = meta:///mp3/plattenspieler?name=alles

Attach logfile if applicable



2022-01-03 15-23-35.845 [Info] (PcmStream) State changed: plattenspieler, state: idle => playing                  
2022-01-03 15-23-35.845 [Info] (Server) onStateChanged (plattenspieler): playing                                  
2022-01-03 15-23-35.846 [Debug] (MetaStream) onStateChanged: plattenspieler, state: playing                       
2022-01-03 15-23-35.846 [Info] (MetaStream) Stream: alles, switching active stream: mp3 => plattenspieler         
/usr/include/c++/10.2.0/optional:441: constexpr _Tp& std::_Optional_base_impl<_Tp, _Dp>::_M_get() [with _Tp = Meta
data; _Dp = std::_Optional_base<Metadata, false, false>]: Assertion 'this->_M_is_engaged()' failed.               
Aborted            

EDIT: downgrading to 0.25.0 solved the issue for now.

@badaix
Copy link
Owner

badaix commented Jan 4, 2022

I cannot reproduce it, but b4a41e0 should fix it. Please try with the current develop branch.

@fuchsmich
Copy link
Contributor Author

Ok, I'll give it a try.

@fuchsmich
Copy link
Contributor Author

I managed to build and install the develop branch.

This issue seems to be solved by this.

@badaix badaix added the next release fixed in develop branch and will be part of the next release label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

No branches or pull requests

2 participants