Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build (without lock) fails – mdbook has undone their breaking update to their public toml dependency #45

Closed
steffahn opened this issue Aug 5, 2023 · 1 comment

Comments

@steffahn
Copy link

steffahn commented Aug 5, 2023

Here’s the revert in mdbook’s repo. Here’s the relevant PR in this repo that made mdbook-toc follow the change (to fix build errors at the time).

And the unsurprising compilation error

    Checking mdbook-toc v0.14.0 (/…/mdbook-toc)
error[E0277]: the trait bound `Config: From<Option<&toml::map::Map<std::string::String, toml::value::Value>>>` is not satisfied
  --> src/lib.rs:80:60
   |
80 |         let cfg = ctx.config.get_preprocessor(self.name()).try_into()?;
   |                                                            ^^^^^^^^ the trait `From<Option<&toml::map::Map<std::string::String, toml::value::Value>>>` is not implemented for `Config`
   |
   = note: required for `Option<&toml::map::Map<std::string::String, toml::value::Value>>` to implement `Into<Config>`
   = note: required for `Config` to implement `TryFrom<Option<&toml::map::Map<std::string::String, toml::value::Value>>>`
   = note: required for `Option<&toml::map::Map<std::string::String, toml::value::Value>>` to implement `TryInto<Config>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `mdbook-toc` (lib) due to previous error
@steffahn steffahn changed the title Build (without lock) fails – mdbook has undone their breaking update to toml Build (without lock) fails – mdbook has undone their breaking update to their public toml dependency Aug 5, 2023
@badboy
Copy link
Owner

badboy commented Aug 5, 2023

-_- we did the same dance a while ago.

@badboy badboy closed this as completed in febe468 Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants