-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unpublished fork ricardoboss/easysvg
#87
Comments
Sure! @JellyBellyDev |
Cannot install v2.3 $ composer require badges/poser:^2.3
./composer.json has been updated
Running composer update badges/poser
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires badges/poser ^2.3 -> satisfiable by badges/poser[v2.3.0, 2.x-dev].
- badges/poser[v2.3.0, ..., 2.x-dev] require kartsims/easysvg ^2.0 -> found kartsims/easysvg[dev-master, 1.0] but it does not match the constraint. Previous badges were implemented without extra dependency 😢 |
You need to add my fork as a repository so composer can find version 2.3: "repositories": [
{
"type": "vcs",
"url": "https://github.com/ricardoboss/easysvg"
}
] Once my fork (kartsims/easysvg#32) is merged, this will no longer be necessary |
@ricardoboss thank you for the example. How this dependency is better than solution with font size detection implemented in other badges? |
In my original PR, I used this library to not only calculate the font size, but also to generate SVG paths for the letters in the badge. Later, after revisiting which fonts are used, I merely used the library for it's features with letter spacing and kerning. If I remember correctly, the current implementation for text width calculation doesn't support this. Also, the |
@JellyBellyDev @antonkomarev A new version of |
Bug Report
Summary
Remove unpublished fork
ricardoboss/easysvg
deps to composer.json as soon as the PR is released: kartsims/easysvg#32Assigned to @ricardoboss :)
Ok?
The text was updated successfully, but these errors were encountered: