From a713669ee8c30c2f239c9c8a74e3175f2549b1a6 Mon Sep 17 00:00:00 2001
From: jNullj <15849761+jNullj@users.noreply.github.com>
Date: Sat, 9 Mar 2024 12:40:22 +0200
Subject: [PATCH] Improve error handling in getServiceClassAuthOrigin

Enhance reliability by throwing a TypeError when a service key definition is missing.
It's common for a key to be missing and might require the developer that writes tests to provide a fake on that fits the examples used.

Key changes:
- Added a check for missing service key definitions in getServiceClassAuthOrigin.
- Throws a TypeError with a clear message if the key is not found.
- Guides devs to use an override if needed which is often.
---
 services/test-helpers.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/services/test-helpers.js b/services/test-helpers.js
index a892b57f6a9af..34fefdbd5f07d 100644
--- a/services/test-helpers.js
+++ b/services/test-helpers.js
@@ -187,6 +187,11 @@ function getServiceClassAuthOrigin(serviceClass, authOverride, configOverride) {
     return serviceClass.auth.authorizedOrigins
   } else {
     const mergedConfig = _.merge(runnerConfig, configOverride)
+    if (!mergedConfig.public.services[auth.serviceKey]) {
+      throw new TypeError(
+        `Missing service key defenition for ${auth.serviceKey}: Use an override if applicable.`,
+      )
+    }
     return [mergedConfig.public.services[auth.serviceKey].authorizedOrigins]
   }
 }