Throw NotFound when license not found

badges · May 18, 2021 · c8692bc · c8692bc
1 parent ffaa723
commit c8692bc
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/services/packagist/packagist-license.service.js b/services/packagist/packagist-license.service.js
@@ -3,6 +3,7 @@
 const Joi = require('joi')
 const { renderLicenseBadge } = require('../licenses')
 const { optionalUrl } = require('../validators')
+const { NotFound } = require('..')
 const {
   keywords,
   BasePackagistService,
@@ -60,6 +61,10 @@ module.exports = class PackagistLicense extends BasePackagistService {
 
     const license = json.packages[packageName][0].license
 
+    if (!license) {
+      throw new NotFound({ prettyMessage: 'license not found' })
+    }
+
     return { license }
   }
 

diff --git a/services/packagist/packagist-license.spec.js b/services/packagist/packagist-license.spec.js
@@ -1,6 +1,7 @@
 'use strict'
 
 const { expect } = require('chai')
+const { NotFound } = require('..')
 const PackagistLicense = require('./packagist-license.service')
 
 describe('PackagistLicense', function () {
@@ -30,4 +31,29 @@ describe('PackagistLicense', function () {
       .to.have.property('license')
       .that.equals('MIT-latest')
   })
+
+  it('should throw NotFound when license key not in response', function () {
+    const json = {
+      packages: {
+        'frodo/the-one-package': [
+          {
+            version: '1.2.4',
+          },
+          {
+            version: '1.2.3',
+          },
+        ],
+      },
+    }
+
+    expect(() =>
+      PackagistLicense.prototype.transform({
+        json,
+        user: 'frodo',
+        repo: 'the-one-package',
+      })
+    )
+      .to.throw(NotFound)
+      .with.property('prettyMessage', 'license not found')
+  })
 })