Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield not displayed if repository contains "-" #1131

Closed
offa opened this issue Oct 4, 2017 · 4 comments
Closed

Shield not displayed if repository contains "-" #1131

offa opened this issue Oct 4, 2017 · 4 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@offa
Copy link

offa commented Oct 4, 2017

I have a repository which contains a - in the path. Unfortunately this prevents shields from being displayed on Github.

Example

Eg. following markdown from shields.io is not shown:

[![GitHub issues](https://img.shields.io/github/issues/offa/scope-guard.svg)](https://github.com/offa/scope-guard/issues)

Same happens for release or Travis shield. Replacing - with -- has no effect. So this wont work either:

[![GitHub release](https://img.shields.io/github/release/offa/scope--guard.svg)](https://github.com/offa/scope-guard/releases)

Is there a way to get this working?

@paulmelnikow paulmelnikow added operations Hosting, monitoring, and reliability for the production badge servers question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Oct 4, 2017
@paulmelnikow
Copy link
Member

This is what I'm seeing:

https://img.shields.io/github/issues/offa/scope-guard.svg

screen shot 2017-10-04 at 3 02 55 pm

So I suspect this is an intermittent problem with the Github badge, due to Shields not having enough tokens for our API usage. Or possibly it could be due to #1119.

You can contribute some of your API quota to Shields, or ask other people interested in your project to do the same: https://img.shields.io/github-auth

It's also possible it was recently fixed and the busted image is cached on your machine, though usually with errors like this you'll see the wrong badge, not no badge, and if this is the first time you've tried to make the badge, it wouldn't be in your cache.

@offa
Copy link
Author

offa commented Oct 4, 2017

If I open the url in the Browser I can see it too. However from Markdown it's not shown. The Readme should show 4 Shields, but I see only 2. I checked on another system and asked someone, both times all 4 are shown. Seem related to my system. I'll clean my browser and test again.

So from a general perspective, this should work (And I don't need the -- for build / release)?

@paulmelnikow
Copy link
Member

Yea, this markdown is working fine.

[![GitHub issues](https://img.shields.io/github/issues/offa/scope-guard.svg)](https://github.com/offa/scope-guard/issues)
[![GitHub release](https://img.shields.io/github/release/offa/scope-guard.svg)](https://github.com/offa/scope-guard/releases)

I'm seeing four badges in your readme too.

@offa
Copy link
Author

offa commented Oct 4, 2017

Finally figured out what caused the problem: The UBlock plugin filtered those two. But only on this system (others with same settings work fine) and only on this project, all other projects, links and systems aren't affected. This also explains why it stopped working suddenly.

@paulmelnikow Thanks for having the time (and giving the final hint).

@offa offa closed this as completed Oct 4, 2017
@paulmelnikow paulmelnikow removed the operations Hosting, monitoring, and reliability for the production badge servers label Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

2 participants