-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Climate's 100% coverage shows red #1329
Comments
Thanks for your report, I'll look into it. 😉 |
The code in shields basically constructs the code coverage badge shown in your screenshot by retrieving the headers from Code Climate's own badges, in your case this one. The information displayed by Code Climate seems to have changed recently, switching from showing a score ( Good news is that the service tests picked this up, and one test is now failing. I am unsure how to approach this problem. As far as I can tell, most of their APIs seem to require authentication (see the documentation). We do seem to be able to publicly access By the way, other Code Climate badges seem to be broken on shield's homepage. As a side note, they have warned us that their API is likely to change:
|
Does the work in #1236 shed any light on this? |
Well the initial pull request comment is in line with my analysis above regarding the first API request and subsequent badge information retrieval, so at least we all agree on what the code was previously supposed to do. ^^ Unfortunately one of the two badges added by that pull request are no longer working as expected as a consequence of a recent Code Climate change and we have to come up with a different approach to retrieve the now missing information. |
#1368 has been merged. Should this be closed? |
I believe this issue can be closed, as #1387 is now merged. 😉 |
I noticed Code Climate's coverage shows red even if i got 100% coverage, is this expected behavior? shouldn't it be green?
The text was updated successfully, but these errors were encountered: