Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shippable badge colors not changing #1571

Closed
wltjr opened this issue Mar 13, 2018 · 5 comments
Closed

Shippable badge colors not changing #1571

wltjr opened this issue Mar 13, 2018 · 5 comments
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@wltjr
Copy link

wltjr commented Mar 13, 2018

I have both badges for Travis and Shippable set for the build text area normally gray to be purple. For some reason across all my projects. The badge for Shippable does not change color. The code is the same for Travis and Shippable badges, with regard to changing color A.

[![Build Status](https://img.shields.io/travis/Obsidian-StudiosInc/os-xtoo/master.svg?colorA=9977bb&style=plastic)](https://travis-ci.org/Obsidian-StudiosInc/os-xtoo)
[![Build Status](https://img.shields.io/shippable/5840e5d8e2ab4d0f0058b4b7/master.svg?colorA=9977bb&style=plastic)](https://app.shippable.com/projects/5840e5d8e2ab4d0f0058b4b7/)

But you can see they render differently. Both plastic style, but only Travis colors update, Shippable does not, no clue why.
Build Status Build Status

If someone could look into and address that issue, it would be greatly appreciated!!! Thank you!

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Mar 13, 2018
@PyvesB
Copy link
Member

PyvesB commented Mar 13, 2018

Hello @wltjr !

Thanks for reporting this, I'll have a look into the problem and see whether I can spot any issues with our implementation. 😉

Cheers,

Pyves

@PyvesB PyvesB self-assigned this Mar 13, 2018
@wltjr
Copy link
Author

wltjr commented Mar 13, 2018

Your welcome, and thanks for taking a look. Its a minor issue.

@PyvesB
Copy link
Member

PyvesB commented Mar 13, 2018

After looking through the code, if I'm not mistaken, this has already been fixed by @chris48s when he worked on pull request #1362.

Previously we had the following snippet in the code for the Shippable badge:
badgeData.colorA = defaultOpts.colorA;

This was basically overriding anything set by the user inside the URL.

Unfortunately the relevant pull request was merged just after our last release to production, so the fix is not yet actually available. Let's be patient! ^^

@wltjr
Copy link
Author

wltjr commented Mar 13, 2018

Oh ok, so I had nice timing. Seen this for a while, finally file an issue after its been fixed. figures... No worries, no rush. Glad its been addressed already!

@PyvesB PyvesB removed their assignment Mar 13, 2018
@paulmelnikow paulmelnikow removed the bug Bugs in badges and the frontend label Mar 15, 2018
@paulmelnikow
Copy link
Member

Meanwhile if you'd like to confirm for yourself that it's fixed, you could try the staging server: https://shields-staging.herokuapp.com

Let's track the deploy status in #1538. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

3 participants