Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise from shields-ci and shields-deployment bots #1827

Closed
tooomm opened this issue Aug 1, 2018 · 3 comments
Closed

Reduce noise from shields-ci and shields-deployment bots #1827

tooomm opened this issue Aug 1, 2018 · 3 comments
Labels
developer-experience Dev tooling, test framework, and CI

Comments

@tooomm
Copy link
Contributor

tooomm commented Aug 1, 2018

The shields-ci bot (danger) currently says thank you in every PR, to all kind of contributors.
Maybe reduce that the new contributors only (if possible). It would be more helpful if it provides some useful link or hint in a way to those first timers.

The other hints like doc updates or warnings are fine I think.

See #1822 (comment)


Also, from #1826 (comment)

We may also want to disable the shields-deployment [bot] status info (for dependabot update PR's).

👍 Addressed in #1924

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 1, 2018
@tooomm tooomm changed the title Reduce noise from shields-ci bot Reduce noise from shields-ci and shields-deployment bots Aug 8, 2018
@chris48s
Copy link
Member

This should be sorted now #1843 and #1924 are merged

@tooomm
Copy link
Contributor Author

tooomm commented Aug 29, 2018

While #1843 stops danger from running on dependabot PR's (👍), it doesn't deal with

The shields-ci bot (danger) currently says thank you in every PR, to all kind of contributors.
Maybe reduce that the new contributors only (if possible). It would be more helpful if it provides some useful link or hint in a way to those first timers.

After thinking about it a bit more it's ok to have the bot reserve the first comment slot for potential edits and helpful hints with the thank you message.

But could the message be different for first timers to include some helpful links maybe?
"✨ Thanks for your first contribution to Shields, @tooomm!"
"Please have a look at our CONTRIBUTING hints and don't hesitate to ask questions at Discord."

and for others:
"✨ Thanks for your continuous (repeated?) contribution to Shields, @tooomm!"

A bit different idea 😄:
There could also be some gamification, if we check the commit count for example and show nicer, special messages to people who contribute more.

@chris48s
Copy link
Member

I'm not sure off the top of my head how to efficiently work out if the user submitting the PR has previously contributed to the repository or not (when I say "efficiently", I mean using either the data provided by danger in the danger.github object or one additional GitHub API call), but I'm sure it is do-able. If anyone wants to pick this up, this probot integration https://github.com/behaviorbot/new-pr-welcome does it, so the code for that probably contains the answer to that question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

No branches or pull requests

3 participants