-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce noise from shields-ci and shields-deployment bots #1827
Comments
While #1843 stops danger from running on dependabot PR's (👍), it doesn't deal with
After thinking about it a bit more it's ok to have the bot reserve the first comment slot for potential edits and helpful hints with the thank you message. But could the message be different for first timers to include some helpful links maybe? and for others: A bit different idea 😄: |
I'm not sure off the top of my head how to efficiently work out if the user submitting the PR has previously contributed to the repository or not (when I say "efficiently", I mean using either the data provided by danger in the |
The shields-ci bot (danger) currently says thank you in every PR, to all kind of contributors.
Maybe reduce that the new contributors only (if possible). It would be more helpful if it provides some useful link or hint in a way to those first timers.
The other hints like doc updates or warnings are fine I think.
See #1822 (comment)
Also, from #1826 (comment)👍 Addressed in #1924
The text was updated successfully, but these errors were encountered: