-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New badge design #224
Comments
Just updating the thread with conversations over twitter.
|
I have allowed for usage of the flat style badge in pypip.in but my users don't want to use it. All of the usage is for the original rounded corner styling (due to it being the same as what they already know and use from coveralls and travis). I personally like the flat style and use it myself but, I'm not keen on this new style shown above which feels very iOS/Apple to me. If we could keep the original rounded corners (pypip.in has to default to this) as well as the current flat style if this new one is also used, that would be good. |
That is something that was requested elsewhere, multiple times. Right now, flat badges have between 14% and 20% usage on Shields. If I change the flat design to have rounded corners, I'm not sure whether there will be unhappiness. It is a small design change for the better, so I feel it is unnecessary to fork the current flat design into, say, "?style=rounded-flat".
The request for a flat design originated from Travis, actually. They felt it would be good eventually to change. As it turns out, @maxogden implemented a patch a month or two later. I assume it is unrelated, but I don't know. By the way, @maxogden, what do you think of changing the flat design to have rounded corners? |
As long as the old-old design stays in place, I think my users should be happy. As for the flat design, I personally like it without rounded corners, maybe if we could get a colourised mock up of the changes to the flat design. I really am not a fan of the white background with the coloured text. I have to admit it's a little hard for me to read. I have perfect vision but I am red-green colourblind, maybe that has something to do with it? Outside of that, I personally just don't like the lack of colour compared to the existing flat design/ |
As @espadrine pointed out, this conversation has been happening over and over again. And every single time, the arguments for a new design boil down to:
My response sadly hasn't changed:
Now @rstacruz, the current badge has not been in place for many years. It's barely more than 1.5 years old, which shows you how fleeting the aesthetic trends tend to be. As we've discussed at length in #95, I don't think we should consider a new design unless it specifically improves on the design goals stated in our specification. If you can suggest a new design that does this, I think it's absolutely fair that we should consider switching to it. Although as @espadrine showed with his stats, this is not a small undertaking and brings the risk of fragmenting the landscape since it might take a long time for the existing badge users to update. Here's what I think isn't satisfying with your design:
I'm closing this issue as a dupe of #95. Please feel free to continue the conversation there since there are many contributors to this project who have a stake in hearing what you have to say. |
The current badge style has been in place for many years now and feels a little out-of-place with current design trends.
How would you guys feel about a more simplified look?
Here it is in the context of a Github readme:
The text was updated successfully, but these errors were encountered: