Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse GitHub URL to create Travis badge #2420

Open
techtonik opened this issue Nov 29, 2018 · 7 comments
Open

Parse GitHub URL to create Travis badge #2420

techtonik opened this issue Nov 29, 2018 · 7 comments
Labels
frontend The React app and the infrastructure that supports it

Comments

@techtonik
Copy link
Contributor

This is the current form for Travis CI badge.

image

And editing it to point to Travis CI is cumbersome. It will be more intuitive if the interface could parse the link automatically. I am willing to do this, but I need some guidance as I don't know React at all, and a pointer to the place of the code where I can change this behavior.

@techtonik
Copy link
Contributor Author

Legacy service?

const LegacyService = require('../legacy-service')

Is there a porting guide to "new" kind of services that can be pointed to from https://github.com/badges/shields/blob/master/services/legacy-service.js ?

@paulmelnikow
Copy link
Member

Is there a porting guide to "new" kind of services that can be pointed to from https://github.com/badges/shields/blob/master/services/legacy-service.js ?

There is now!
https://github.com/badges/shields/blob/master/doc/rewriting-services.md

@paulmelnikow
Copy link
Member

Hi! If I understand this request correctly, it's a refinement of #701. Rather than individual fields, there would be a place to paste the GitHub URL. Nice idea!

Also worth doing, and easier to tackle quickly, is to add Travis to the badge suggestions. That would be done in the suggestion API. The way a user would access it is by pasting a github URL into the search/suggest box and clicking Suggest Badges. This is momentarily blocked on #2441 which is modifying that endpoint, though you could grab that branch and start playing with the suggest feature if you'd like.

There's a bunch of work underway for the general case (#701) which I think needs to land first. Then there probably needs to be a flag in the service definition for services whose URLs can be inferred from a GitHub URL, and new some code in the front end to do that.

I'd suggest reading #2441 as a good place to start. Feel free to post comments and questions.

@paulmelnikow paulmelnikow added the frontend The React app and the infrastructure that supports it label Dec 3, 2018
@techtonik
Copy link
Contributor Author

Looks like Suggest Badges is broken on FF. If I paste https://github.com/badges/shields/ no suggestions are proposed.

Still trying to get the time for React.

@paulmelnikow
Copy link
Member

Fixed in #2604.

@techtonik

This comment has been minimized.

@paulmelnikow

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it
Projects
None yet
Development

No branches or pull requests

2 participants