You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already show a warning when services haven't been tested, though we don't compare that against the service names in the PR title. This should be pretty straightforward to do using the helper functions we have.
I'm not sure if Danger has access to the PR metadata, though we could generate it easily enough in an earlier step in the CI, using npm run test:services:pr:prepare.
The text was updated successfully, but these errors were encountered:
Maybe we should run service tests for all modified services? Was it discussed before? With this approach you will not need to add service name to PR title and this would be a very user friendly.
One thing new since #1936 is that GitHub Actions have come online. I am not completely sure, though I think they provide a UI that lets users trigger actions. I'm not sure if you can set options for those actions. Might be worth an investigation, though! (Much easier than setting up Drone!)
Also along the original line of the issue, a danger warning is a nice place to start, because we can get a feel for how well the detection is working (false positives and false negatives) over a long period of time before we wire it up to the service-test run.
We already show a warning when services haven't been tested, though we don't compare that against the service names in the PR title. This should be pretty straightforward to do using the helper functions we have.
I'm not sure if Danger has access to the PR metadata, though we could generate it easily enough in an earlier step in the CI, using
npm run test:services:pr:prepare
.The text was updated successfully, but these errors were encountered: