-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver #36
Comments
@joshbeitler How should that look exactly? Just a batch with a version number? Or something else? |
Sort of like this: . Something like this was suggested here on the Semver issue page. |
Yeah. That looks good. Maybe it would encourage the java folks to use semver! :-D |
Ha! |
👍 |
Allow me to be the usability nutcracker here, but that In keeping with the idea of making open source projects approachable I would rather spell things out than use initials or even abbreviations:
Plain and simple, no frills. If you're semantic, it's explicit and you can boast it. If you're not, we don't mention it. What do you folks think? |
@olivierlacan I agree! +1 |
That seems like a much better idea than my initial suggestion 👍 |
I really love this idea and would love to express that I'm a part of Semantic Versioning more in my projects 👍 How would you catch every single possible version number as well as prerelease version number though? Or can the version number part be generated by how you link it? |
@Jamesking56 it would probably be dynamic, yes. |
But wouldn't that mean that every new version you would have to update Readme.md with the new version number? The other status badges for services update themselves but this one seems to require manual updating? On 9 Aug 2013, at 05:00 PM, Nicholas Acker notifications@github.com wrote:
|
I like @olivierlacan's idea that we use two badges related to versioning: one would be for the version number of the package in question, and the other for the version of SemVer in use. So it'd look like this: ![](http://origin-shields-io.herokuapp.com/semantic version/v2.0.0.png?color=green) Or maybe even: The package version could be resolved dynamically using the relevant package repo (packagist, npm, rubygems, pypi, cpan, etc.) as the backing service. Since the version of SemVer you're using wouldn't change that often, it's less onerous for that to be static in your markdown. The above would look something like this:
We could then dynamically color-code the SemVer badges based on the age of the version of the SemVer spec in use. Maybe green for the latest version of SemVer, yellow for pre-releases of the latest version, and red for old versions? |
It would be easy to add a SemVer service once we land #44. |
Yeah, once this is a service maybe then we can just login to some backend to update the version number or maybe it might be easier to use GitHub's API to get the Releases on a repo and use the version number on that? |
Or read it from setup.py/AssemblyInfo.cs etc. and try to parse it as SemVer. |
For what it's worth, I was the one who created the original badge task on the SemVer repo. My preference is to construct READMEs such that the badge shows the version of my project, and links to the spec for the SemVer version in use. That way you're not bombarding the user with too much information, but there's no ambiguity as to the scheme in use. I haven't found updating the README for each release to be problematic as I just do it at the same time as the CHANGELOG. |
On semver/semver#104 (comment), @Tieske suggests:
Here's what that might look like: ![](http://origin-shields-io.herokuapp.com/version/1.2.3 sv2.0.0.png?color=green) |
@whit537 How legible is that for someone who doesn't know what This doesn't satisfy the "semantic" goal of Shields at the moment. I still favor one badge that says:
and another one that says:
Trying to cram too much information in one badge doesn't look like a good solution. |
Backing @olivierlacan on this one. |
I agree with @olivierlacan actually. |
@olivierlacan Would the |
@whit537 Maybe it should be |
@Jamesking56 I could see that working. |
Or we link |
That's possible, though I would think it would be better all around for that package manager to integrate with Shields in the first place 😄 |
@ackerdev Sure, but the user is still going to copy and paste markdown, right? |
@whit537 Yeah, and they of course can still edit it to do whatever they want... but I would think if this is for SemVer then the badge should point to SemVer by default. |
@ackerdev The SemVer badge certainly should. I was wondering about the version badge. ![](http://origin-shields-io.herokuapp.com/semantic version/v2.0.0.png?color=green)
|
@whit537 What you suggested is the best solution. Two badges will clear out any issue. Also what if the version does not conform semantic versioning and semantic versioning is specified. Should the version badge turn to red? |
When I suggested
I meant the ability to add it to the SemVer version itself, the SemVer string for a package. So if the version would be (with the proposed extension) So as for the badge; I think it should display the version of the package, and the (visual) design should make clear that it uses SemVer (link to the apropriate SemVer version maybe, as @Jamesking56 commented). But I don't see the need to make it display the SemVer version used in the badge. For the future it would probably be best if SemVer would define a logo or some design guidelines for displaying versions so it gets a consistent implementation over all uses (similar to the facebook 'like' logo) |
@whit537 I actually didn't think about it, but Though we do lose some use in declaring it to be semantic versioning this way to the reader. Could just be |
That's a really good idea @Tieske. I created an issue on the semver to suggest that. I think the solution here is simple:
The version badge links to whatever package manager or archive of the version release, while the semver badge links to a specific semver spec version: http://semver.org/spec/v2.0.0.html |
It would be nice to have a shield for Semver that could represent version numbers in a project.
The text was updated successfully, but these errors were encountered: