Support git hash in [nexus] SNAPSHOT version #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasi35
previously approved these changes
Apr 8, 2021
PyvesB
approved these changes
Apr 9, 2021
|
This improvement has been deployed to production! 🍾 |
|
Confirmed it works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SNAPSHOT version pre-check wouldn't match a SNAPSHOT version that includes a hash (git hash, a default convention when using
sbt-dynver). Incidentally, it would match versions with hashes that end with0-9, but not witha-f.There was a test in
nexus.tester.jsthat tested a version with a hash that passed because the hash ended with0-9.i.e.)
Match
No match