use v5 API for [AUR] badges #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calebcartwright
commented
Jul 29, 2021
| const { license } = this.transform(json) | ||
| return this.constructor.render({ license }) | ||
| const { licenses } = this.transform(json) | ||
| return renderLicenseBadge({ licenses, color: 'blue' }) |
There was a problem hiding this comment.
I opted to extend our license badge helper to let call sites specify a default color to use instead of the dynamically derived colors based on the license values. This seems a reasonable change in its own right, though opted to do so here since we have historically hardcoded the color for this badge and didn't want to introduce color changes as part of updating to the latest API
chris48s
reviewed
Jul 29, 2021
Co-authored-by: chris48s <chris48s@users.noreply.github.com>
chris48s
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6835