[freecodecamp]: allow + symbol in username

[SethFalco]

Related

• Fixes TypeError: Cannot destructure property 'points' of 'entities.user[username]' as it is undefined. #6998

Problem

The pattern I used in the schema instance in freecodecamp-points.service.js was wrong.

I used \w because I thought usernames could only have letters, numbers, hyphens and underscores. I wasn't aware they could have plus until now. Then allowAndStripUnknownKeys kicked off and removed the properties that didn't match the pattern defined, including usernames with a + in it.

Solution

I stole the pattern used to validate usernames from the official freeCodeCamp repository this time, so it should match this time.

const validCharsRE = /^[a-zA-Z0-9\-_+]*$/;

— https://github.com/freeCodeCamp/freeCodeCamp/blob/main/utils/validate.js#L14

Now it handles + symbols correctly.

[shields-ci]

	Warnings
⚠️	This PR modified service code for freecodecamp but not its test code. That's okay so long as it's refactoring existing code.

	Messages
📖	✨ Thanks for your contribution to Shields, @SethFalco!

Generated by 🚫 dangerJS against fa747fa

[calebcartwright]

Was going to say it might be helpful to add a tests for this but I think the comment covers it sufficiently.

Thank you!