Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply consistent button styling #7172

Closed
paulmelnikow opened this issue Oct 19, 2021 · 5 comments
Closed

Apply consistent button styling #7172

paulmelnikow opened this issue Oct 19, 2021 · 5 comments
Labels
frontend The React app and the infrastructure that supports it good first issue New contributors, join in!

Comments

@paulmelnikow
Copy link
Member

As suggested in #7129, let's adopt a consistent style for the action buttons on the site, in place of the default button styles we've got in place now.

In terms of a design process, let's agree on the visual design in this thread and then once the design is approved, open a PR.

My suggestion as a starting point would be to mimic the styling of the button on the badge customizer (but without the dropdown):

Screen Shot 2021-10-19 at 2 42 14 PM

@paulmelnikow paulmelnikow added frontend The React app and the infrastructure that supports it good first issue New contributors, join in! labels Oct 19, 2021
@Andre601
Copy link

I feel like that this one is a good idea, but maybe leave away the gradient. A more flat colour palette without gradient (i.e. Material theme-like) seems to be a very popular solution, which makes sense since it's kinda time-less in design while gradients lose their charm quickly.

Also, not the biggest fan of this blue tbh. Maybe use a green colour instead for positive actions (make badge, copy URL, etc.)?

@paulmelnikow
Copy link
Member Author

Happy for us to remove the gradient. In terms of action-button color, I think using the azureish blue is clearer than green, in part because the color is further from the Shields badge color scheme, so it makes a clearer difference between the action buttons and the example badges. I don't think action buttons need to be green.

@Andre601
Copy link

Of course. The important part here is to just find a consistent colouring in terms of what action-type should have what colour and such. This should perhaps go after #7176 to avoid bad colour combinations or badly readable buttons.

@itsajay1029
Copy link

Hey @paulmelnikow , can you assign me this issue so that I can get started working on it ?

@chris48s
Copy link
Member

We have just launched a completely redesigned frontend https://shields.io/

Closing this issue as it relates to the previous frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it good first issue New contributors, join in!
Projects
None yet
Development

No branches or pull requests

4 participants