-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove no download handling and add API warning to [Wordpress] badges #7606
Conversation
@@ -78,7 +79,7 @@ function StarsForExtensionType(extensionType) { | |||
staticPreview: this.render({ | |||
rating: 80, | |||
}), | |||
documentation: 'There is an alias <code>/r/:slug.svg</code> as well.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not consistent with our usage of the /r/
abbreviation in the rating category, I chose to stop advertising it in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Based on the comment in https://meta.trac.wordpress.org/ticket/6061#comment:3 and https://meta.trac.wordpress.org/ticket/6061#comment:5 do we want to apply this documentation to all wordpress badges (including the ones calling the |
Yeah, I did hesitate, and was leaning slightly towards applying the documentation everywhere for three reasons:
I don't feel too strongly though, so happy to go down the other route if you think it's preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds reasonable
Fixes #7356.