Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [PUB] likes badge #7916

Merged
merged 3 commits into from
May 5, 2022
Merged

add [PUB] likes badge #7916

merged 3 commits into from
May 5, 2022

Conversation

G1Joshi
Copy link
Contributor

@G1Joshi G1Joshi commented May 1, 2022

@shields-ci
Copy link

shields-ci commented May 1, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @G1Joshi!

Generated by 🚫 dangerJS against 75d0360

@G1Joshi
Copy link
Contributor Author

G1Joshi commented May 1, 2022

This PR depends on #7921.
All tests will pass after merging the above-mentioned PR.

chris48s
chris48s reviewed May 3, 2022
View reviewed changes
services/pub/pub-likes.service.js Outdated Show resolved Hide resolved
services/pub/pub-likes.service.js Outdated Show resolved Hide resolved
services/pub/pub-likes.service.js Outdated Show resolved Hide resolved
This was referenced May 3, 2022
Merged
Merged
@G1Joshi G1Joshi requested a review from chris48s May 4, 2022 17:37
@calebcartwright
Copy link
Member

Could you rebase when you get a chance to pull in the test fixes

@G1Joshi
Copy link
Contributor Author

G1Joshi commented May 5, 2022

Could you rebase when you get a chance to pull in the test fixes

Done :)

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs squash when passing labels May 5, 2022
@repo-ranger repo-ranger bot merged commit 3ac24d3 into badges:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add [PUB] likes badge
4 participants
@G1Joshi @shields-ci @calebcartwright @chris48s