Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitLab logo (2022) #7984

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented May 19, 2022

Updates GitLab logo.

GitLab logo was updated on 2022-04-27 by https://github.com/GitLab: https://about.gitlab.com/blog/2022/04/27/devops-is-at-the-center-of-gitlab/

Note that https://github.com/gitlabhq updated its icon, but https://github.com/GitLab did not.

Checklist

  • Minimize SVG files through SVGO
  • Set a viewbox and ensure the logo is scaled to fit the viewbox, while preserving the logo's original proportions. This means the icon should be touching at least two sides of the viewbox.
  • Ensure the logo is vertically and horizontally centered.
  • Ensure the logo is minified to a single line with no formatting.
  • Ensure the SVG does not contain extraneous attributes.
  • Ensure your submission conforms to any relevant brand or logo guidelines.

Minimize SVG files through SVGO

$ svgo --precision=3 logo/gitlab.svg

gitlab.svg:
Done in 50 ms!
0.981 KiB - 1.9% = 0.963 KiB

from https://github.com/badges/shields/blob/e94b9c104707da81f1e01451d59695905772a5db/doc/logos.md

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Note

These PRs did not help updating the logo:

cf.

@shields-ci
Copy link

shields-ci commented May 19, 2022

Messages
📖 ✨ Thanks for your contribution to Shields, @tnir!

Generated by 🚫 dangerJS against 74e7076

@calebcartwright calebcartwright changed the title [GitLab] Update GitLab logo (2022) Update GitLab logo (2022) May 21, 2022
@calebcartwright calebcartwright added the frontend The Docusaurus app serving the docs site label May 21, 2022
@calebcartwright
Copy link
Member

think we should proceed with this in the same vein as #7831

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm but i'll hold off on merging in case another maintainer wants to weigh in

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with changing the logo, but can you make sure the new logo has been minified in line with our image contribution guidelines: https://github.com/badges/shields/blob/master/doc/logos.md#contributing-logos

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir
Copy link
Contributor Author

tnir commented May 23, 2022

@chris48s Updated.

@repo-ranger repo-ranger bot merged commit 22380c5 into badges:master May 23, 2022
@tnir tnir deleted the tnir/gitlab-logo-2022 branch May 24, 2022 02:05
@tnir
Copy link
Contributor Author

tnir commented May 24, 2022

Thanks @chris48s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The Docusaurus app serving the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants