-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pypi] Add Framework Version Badges support #8261
[pypi] Add Framework Version Badges support #8261
Conversation
This pull request introduces 2 alerts when merging 8133c76 into 202d72d - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up. The implementation is looking pretty good already but I've left a few comments inline. I was hoping we might be able to get away without explicitly listing the frameworks, but the Jupyter :: JupyterLab
case does make things a bit messy. Fortunately it is quite rare for new classifiers to be added and the way you've written this should make it quite easy to add new ones
This pull request introduces 2 alerts when merging 57f17cf into 9e29d3d - view on LGTM.com new alerts:
|
@chris48s Good comments, I implemented all of them. |
This pull request introduces 2 alerts when merging 10d027b into 9e29d3d - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
8 for the price of one
This pull request introduces 2 alerts when merging 0ef8c12 into 9e29d3d - view on LGTM.com new alerts:
|
Implements #8246
/pypi/frameworkversions/:frameworkName/:packageName
/pypi/djversion/:packageName
to/pypi/frameworkversions/Django/:packageName