get the tests passing on windows #8350
Conversation
chris48s
added
bug
|
d313935 includes the fix suggested in #8289 (comment) which gets most of the tests passing. There are still a few more failures I've not looked into yet. For the moment I've just started with the core tests. |
..and add comment explaining why we need to do this
chris48s
changed the title
|
Right.. rest of the tests should be fixed, mysteries solved. The reason for the behaviour change with paths (relatively) recently is due to a behaviour change in glob when we upgraded from 7.2 to 8.0: https://github.com/isaacs/node-glob/blob/main/changelog.md#80 |
| @@ -1,5 +1,7 @@ | |||
| function svg2base64(svg) { | |||
| return `data:image/svg+xml;base64,${Buffer.from(svg).toString('base64')}` | |||
| return `data:image/svg+xml;base64,${Buffer.from(svg.trim()).toString( | |||
There was a problem hiding this comment.
The difference in the logo tests was a \n vs \r\n issue. I decided that really the best thing to do was just strip any kind of trailing whitspace rather than try to normalise it as any trailing whitspace after the final > is doing nothing of use anyway so 🤷
|
Cool. It may also be worth running some of the other test suites on Windows as well as linux - these kind of issues could happen in the frontend/package/etc too, but also I'm slightly wary of "build matrix inflation" (for want of a better term). Interested if you have any thoughts on that point.. |
Yeah I know what you mean, and it's especially true in my experience with GHA because of how granularly each leg shows up under the check status view. I think my main interest for Windows is largely just to give us back a high degree of confidence that contributors on Windows can clone + install, then start the app, I'm much less concerned with having an exhaustive/equal testing suite on Windows |
closes #8289
Now that we are running on GHA we can pretty easily just run the tests on Windows and we've got tests covering the functionality in #8289