Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs badges are "always failed" if the package is an executable #8440

Closed
Gankra opened this issue Sep 27, 2022 · 2 comments
Closed

docs.rs badges are "always failed" if the package is an executable #8440

Gankra opened this issue Sep 27, 2022 · 2 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@Gankra
Copy link

Gankra commented Sep 27, 2022

Are you experiencing an issue with...

shields.io

🐞 Description

This clearly functioning documentation page on docs.rs includes a badge for itself... saying the docs failed to build: https://docs.rs/crate/minidump-stackwalk/latest

The badge url is the standard "schema" used by all rust packages for their libraries. It seems that the pipeline here only really understands libraries and considers executables to always be failed.

🔗 Link to the badge

https://docs.rs/minidump-stackwalk/badge.svg

which redirects to

https://img.shields.io/docsrs/minidump-stackwalk/latest

💡 Possible Solution

This may require upstream work with docs.rs. Currently the build report they emit:

https://docs.rs/crate/minidump-stackwalk/latest/builds.json

provides no indication that this is an executable, and indeed specifies build_status: false. I was told to file this bug with y'all, but I expect docs.rs will need to do something for you first.

@Gankra Gankra added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Sep 27, 2022
@chris48s
Copy link
Member

You've kind of answered your own question :) To get the data to render the badge, we call https://docs.rs/crate/minidump-stackwalk/latest/builds.json The reason why we're saying the build status is failed is because https://docs.rs/crate/minidump-stackwalk/latest/builds.json reports build_status: false.

@calebcartwright
Copy link
Member

Going to close this for now given the current plans to update things on the docs.rs side. We can revisit and reopen if it becomes necessary for us to make any changes on this end.

@calebcartwright calebcartwright closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

3 participants