Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix formatRelativeDate error handling; run [date] #8497

Merged
merged 4 commits into from
Oct 8, 2022
Merged

fix formatRelativeDate error handling; run [date] #8497

merged 4 commits into from
Oct 8, 2022

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Oct 7, 2022

This has been causing the relative date service tests to fail with

AssertionError: message mismatch: expected 'nan years ago' to equal 'invalid date'

We broke this when we switched from moment.js to dayjs

@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge keep-service-tests-green Related to fixing failing tests of the services labels Oct 7, 2022
@shields-ci
Copy link

shields-ci commented Oct 7, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against de950a6

@repo-ranger repo-ranger bot merged commit 8f4662b into badges:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend keep-service-tests-green Related to fixing failing tests of the services service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @shields-ci @calebcartwright