Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [modrinth] game versions #8673

Merged
merged 4 commits into from
Dec 31, 2022
Merged

Add [modrinth] game versions #8673

merged 4 commits into from
Dec 31, 2022

Conversation

Insprill
Copy link
Contributor

@Insprill Insprill commented Dec 2, 2022

Adds a badge for Modrinth game versions.

The base routes for similar badges seemed to be all over the place so it's currently modrinth/game-versions. If it should be changed to something else please let me know.

@shields-ci
Copy link

shields-ci commented Dec 2, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @Insprill!

Generated by 🚫 dangerJS against 671e500

PaulaBarszcz
PaulaBarszcz previously approved these changes Dec 10, 2022
View reviewed changes
Copy link
Collaborator

@PaulaBarszcz PaulaBarszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

triphora
triphora previously approved these changes Dec 11, 2022
View reviewed changes
chris48s
chris48s reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it has taken so long to get to this.

I agree the existing routes for platform support badges are a bit of a mess. Lets go with your suggestion. If we decide to tidy these up in future, we can always use a redirect.

services/modrinth/modrinth-game-versions.service.js Outdated Show resolved Hide resolved
@Insprill Insprill dismissed stale reviews from triphora and PaulaBarszcz via dabda53 December 28, 2022 23:36
chris48s
chris48s approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. I'll get this merged/deployed soon 👍

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs squash when passing labels Dec 31, 2022
@repo-ranger repo-ranger bot merged commit efd707e into badges:master Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

@PaulaBarszcz PaulaBarszcz PaulaBarszcz left review comments

@triphora triphora triphora left review comments

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Insprill @shields-ci @chris48s @PaulaBarszcz @triphora