Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various [Polymart] badges #8811

Merged
merged 14 commits into from
Jan 16, 2023
Merged

Conversation

MherZaqaryan
Copy link
Contributor

Added:

  • Polymart Downloads badge
  • Polymart Latest Version badge
  • Polymart Rating badge
  • Polymart Star Rating badge

Closes #7429

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2023

Fails
🚫

Danger failed to run dangerfile.js.

Messages
📖 ✨ Thanks for your contribution to Shields, @MherZaqaryan!

Error Error

ENOENT: no such file or directory, open 'services/polymart/polymart-downloads.tester.js'
Error: ENOENT: no such file or directory, open 'services/polymart/polymart-downloads.tester.js'
    at Object.openSync (node:fs:590:3)
    at Object.readFileSync (node:fs:458:35)
    at _loop_1 (/home/runner/work/shields/shields/node_modules/danger-plugin-no-test-shortcuts/dist/index.js:18:28)
    at noTestShortcuts (/home/runner/work/shields/shields/node_modules/danger-plugin-no-test-shortcuts/dist/index.js:51:9)
    at Object.<anonymous> (dangerfile.js:103:1)
    at Module._compile (node:internal/modules/cjs/loader:1165:14)
    at requireFromString (/home/runner/work/shields/shields/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:157:68
    at step (/home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:23:12)
    at runDangerfileEnvironment (/home/runner/work/shields/shields/node_modules/danger/distribution/runner/runners/inline.js:118:132)
    at /home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:178:38
    at step (/home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:25:53)
    at /home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:19:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:15:12)
    at Object.executeRuntimeEnvironment (/home/runner/work/shields/shields/node_modules/danger/distribution/platforms/GitHub.js:143:88)
    at /home/runner/work/shields/shields/node_modules/danger/distribution/commands/danger-runner.js:100:47
    at step (/home/runner/work/shields/shields/node_modules/danger/distribution/commands/danger-runner.js:34:23)
    at Object.next (/home/runner/work/shields/shields/node_modules/danger/distribution/commands/danger-runner.js:15:53)
    at fulfilled (/home/runner/work/shields/shields/node_modules/danger/distribution/commands/danger-runner.js:6:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Dangerfile

------^

Generated by 🚫 dangerJS against 9f6cf86

@MherZaqaryan
Copy link
Contributor Author

MherZaqaryan commented Jan 15, 2023

@chris48s Hey, I made a new pull request, everything else you said in the previous pull request is now fixed. Also, the specific service to run on Windows is currently working.

One more thing, could you please help me with this Danger thing? I don't understand what's wrong.

@chris48s
Copy link
Member

Thanks! I'm aiming to have another look at this tomorrow.
You can ignore the issue with danger. I need to fix it, but it is unrelated to the changes in this PR.

@MherZaqaryan
Copy link
Contributor Author

Thanks! I'm aiming to have another look at this tomorrow. You can ignore the issue with danger. I need to fix it, but it is unrelated to the changes in this PR.

Alright! Thanks for letting me know!

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up again.

services/polymart/polymart-downloads.service.js Outdated Show resolved Hide resolved
services/polymart/polymart-latest-version.service.js Outdated Show resolved Hide resolved
services/polymart/polymart-latest-version.service.js Outdated Show resolved Hide resolved
services/polymart/polymart-latest-version.tester.js Outdated Show resolved Hide resolved
@chris48s
Copy link
Member

We don't need to copy and paste all the code from version.js into your file. We can import renderVersionBadge using import { renderVersionBadge } from '../version.js'.

Maybe looking at something like https://github.com/badges/shields/blob/master/services/cdnjs/cdnjs.service.js as an example would help?

@MherZaqaryan
Copy link
Contributor Author

MherZaqaryan commented Jan 16, 2023

We don't need to copy and paste all the code from version.js into your file. We can import renderVersionBadge using import { renderVersionBadge } from '../version.js'.

Maybe looking at something like https://github.com/badges/shields/blob/master/services/cdnjs/cdnjs.service.js as an example would help?

Yep, thank you, I just fixed it, I actually didn't get a response for my question in the last pull request, and thought that I have to add it manually #8352 (comment)

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Latest changes look good 👍
I'll get this deployed in the next few days

@chris48s chris48s merged commit 7136943 into badges:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge Request: Polymart
2 participants