-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various [Polymart] badges #8811
Conversation
Error Error
Dangerfile
|
@chris48s Hey, I made a new pull request, everything else you said in the previous pull request is now fixed. Also, the specific service to run on Windows is currently working. One more thing, could you please help me with this Danger thing? I don't understand what's wrong. |
Thanks! I'm aiming to have another look at this tomorrow. |
Alright! Thanks for letting me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up again.
Co-authored-by: chris48s <chris48s@users.noreply.github.com>
We don't need to copy and paste all the code from version.js into your file. We can import Maybe looking at something like https://github.com/badges/shields/blob/master/services/cdnjs/cdnjs.service.js as an example would help? |
Yep, thank you, I just fixed it, I actually didn't get a response for my question in the last pull request, and thought that I have to add it manually #8352 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Latest changes look good 👍
I'll get this deployed in the next few days
Added:
Downloads
badgeLatest Version
badgeRating
badgeStar Rating
badgeCloses #7429