Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc minor fixes to [githubsize node pypi] #8946

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

chris48s
Copy link
Member

This is a random grab bag of things I've spotted as I've been plugging away at the docusaurus site.

  1. I found a couple of badges with errors in the route, which I have fixed.
  2. On the examples for the node badges, we've framed the route as /@:scope/:packageName rather than /:scope/:packageName (which is what we do with all the other npm badges). The change I've made is backwards-compatible. Any existing badges will include the @ in the route - it just changes how it is presented in the frontend. This brings the way we present it into line with the other NPM and package.json badges.
  3. I spotted some more HTML that is giving us issues in a similar vein to documentation html fixes #8887 which I've fixed

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs documentation Developer and end-user documentation labels Feb 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2023

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pypi but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for sonar but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against ed740c7

@chris48s chris48s changed the title misc minor fixes to [githubsize node pypi sonar] misc minor fixes to [githubsize node pypi] Feb 26, 2023
@chris48s
Copy link
Member Author

some sonar tests were failing, but unrelated to these changes

@repo-ranger repo-ranger bot merged commit 26bf69c into badges:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants