Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add total commits to [GitHubCommitActivity] #9196

Merged
merged 4 commits into from
May 29, 2023

Conversation

jNullj
Copy link
Collaborator

@jNullj jNullj commented May 23, 2023

As part of a new feature proposed at issue #6070 added the requested feature. I also used the conversation at pull request #6081 as a basis for those changes.

This change adds a new interval to the github/commit-activity shield 'total' (t for short). The interval shows the total commits of the repo since its creation.

photo for fun
image

As part of a new feature proposed at issue badges#6070 added the requested feature.
I also used the conversation at pull request badges#6081 as a basis for those changes.

This change adds a new interval to the github/commit-activity shield 'total' (t for short).
The interval shows the total commits of the repo since its creation.
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 54b05be

@jNullj
Copy link
Collaborator Author

jNullj commented May 23, 2023

A few min, i will run Prettier...

@jNullj
Copy link
Collaborator Author

jNullj commented May 24, 2023

I am changing the label to "commits" when using total interval, wait for the next commit...

Label change for the 'total' interval from 'commit activity' to 'commits'
@calebcartwright
Copy link
Member

It's a little unclear what the current status of this PR is. If you're still in the process of working on things, it's best to mark the PR as a draft so that it's explicitly clear to us it's still a WIP and we don't need to invest much time in looking at it yet.

If you are done and ready for a review, it'd helpful if you could indicate such 👍

@jNullj
Copy link
Collaborator Author

jNullj commented May 26, 2023

Oh, my bad, i am ready for a review.
Is there a dedicated way to indicate the PR is ready for review on github?

@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-9196-badges-shields.fly.dev

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label May 29, 2023
@chris48s
Copy link
Member

on board with this solution 👍

@repo-ranger repo-ranger bot merged commit 8a11db8 into badges:master May 29, 2023
@calebcartwright
Copy link
Member

Oh, my bad, i am ready for a review. Is there a dedicated way to indicate the PR is ready for review on github?

Sorry I forgot to respond to this, but no worries, and yes you can convert a draft PR to a "ready" state as well as mark a "ready" PR as still being in draft-mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants