-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add total commits to [GitHubCommitActivity] #9196
Conversation
As part of a new feature proposed at issue badges#6070 added the requested feature. I also used the conversation at pull request badges#6081 as a basis for those changes. This change adds a new interval to the github/commit-activity shield 'total' (t for short). The interval shows the total commits of the repo since its creation.
A few min, i will run Prettier... |
I am changing the label to "commits" when using total interval, wait for the next commit... |
Label change for the 'total' interval from 'commit activity' to 'commits'
It's a little unclear what the current status of this PR is. If you're still in the process of working on things, it's best to mark the PR as a draft so that it's explicitly clear to us it's still a WIP and we don't need to invest much time in looking at it yet. If you are done and ready for a review, it'd helpful if you could indicate such 👍 |
Oh, my bad, i am ready for a review. |
🚀 Updated review app: https://pr-9196-badges-shields.fly.dev |
on board with this solution 👍 |
Sorry I forgot to respond to this, but no worries, and yes you can convert a draft PR to a "ready" state as well as mark a "ready" PR as still being in draft-mode |
As part of a new feature proposed at issue #6070 added the requested feature. I also used the conversation at pull request #6081 as a basis for those changes.
This change adds a new interval to the github/commit-activity shield 'total' (t for short). The interval shows the total commits of the repo since its creation.
photo for fun