Delete old deprecated services #9254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
the
service-badge
|
calebcartwright
approved these changes
Jun 11, 2023
Comment on lines
+102
to
105
| - David | ||
| - dependabot | ||
| - Dockbit | ||
| - Dotnet Status |
There was a problem hiding this comment.
It's a bit tricky for me to determine whether I think it's worth mentioning the Docker build service here 🤔
I believe what you've got here is probably for the best, since it could be more confusing than helpful to have it listed (i.e. we still have a "Docker Build" badge from the end user pov, the deprecated one just had the nuances of some legacy with the platform and an associated badge route)
There was a problem hiding this comment.
I figured the potential for confusion probably outweighed the benefits, but anyway I'm not convinced this list is read through very often. Let's merge as is :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes a bunch of old deprecated services, as per https://github.com/badges/shields/blob/master/doc/deprecating-badges.md#what-happens-next. All of these were deprecated in 2021 or early 2022.