add a bit of border to select boxes #9348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Jul 3, 2023
| @@ -31,7 +31,7 @@ html[data-theme="dark"] .docusaurus-highlight-code-line { | |||
| color-scheme: initial; | |||
| } | |||
|
|
|||
| input[type="text"] { | |||
| input[type="text"], :not(#fakeID#fakeId#fakeID) select { | |||
There was a problem hiding this comment.
This is not great CSS. Every select box has a couple of classes attached to it with long auto-generated names that I don't really want to use directly. They seem like they may not be reliable over time.
In order to make a more specific selector, I've used this hack https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity#increasing_specificity_by_duplicating_selector
I might have a look at opening a PR to implement this and #9324 upstream at the component layer so we clean this up a bit.
|
calebcartwright
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9324 I added a bit of border to text boxes.
I forgot to add it to select boxes.
Before:
After: