Migrate from [DocsRs]' builds API to status API #9422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Updated review app: https://pr-9422-badges-shields.fly.dev |
chris48s
added
the
service-badge
chris48s
approved these changes
Jul 30, 2023
|
Thanks. Merging 👍 Just a quick comment on the endpoint: It is not a problem for us because we just look at the status code and discard the body for the not found cases, but it would be nicer if the 404 responses like https://docs.rs/crate/not-a-crate/latest/status.json and https://docs.rs/crate/regex/not-a-version/status.json returned a JSON response rather than HTML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify refactoring how our builds are processed I want to remove the
/builds.jsonendpoint on docs.rs. As a replacement I added a new endpoint simply giving the status that sites like shields.io wants: are there docs for this version available to link to. This also fixes some small issues with the old endpoint (some edgecases meant the first build was successful but there were no docs, or there were docs but the first build was marked unsuccessful).